Convert on-machine backend from Nix-Bash into Jq-Bash#15
Open
MagicRB wants to merge 1 commit into
Open
Conversation
MagicRB
force-pushed
the
nix-bash-to-jq-bash
branch
from
7eede70 to
48c1249
Compare
I don't know which is worse, but I prefer the latter. Signed-off-by: magic_rb <magic_rb@redalder.org>
MagicRB
force-pushed
the
nix-bash-to-jq-bash
branch
from
48c1249 to
fd43664
Compare
|
|
||
| # check if all files are present or all files are missing | ||
| # if not, they are in an inconsistent state and we bail out | ||
| while read -u 10 -r _generator_name ; do |
Contributor
There was a problem hiding this comment.
what's with the hard-coded number here? (seeing 2 similar instances below)
Author
There was a problem hiding this comment.
Ah forgot to document, thats to not take over stdin as the code in the while block needs it free.
Contributor
|
i like the approach! mostly just had one minor question. |
KiaraGrouwstra
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know which is worse, but I prefer the latter.
Tested manually and also with the NixOS test. Everything seems to work.